Owners: Promote Gacko to ingress-nginx-maintainers & ingress-nginx-reviewers.
#11165
Conversation
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/triage accepted |
|
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
triage/accepted
|
Thank you for your contributions. I'm happy to see this. |
|
According to my understanding from the docs, owners are getting inherited. At least that already was the case for the chart. You, @tao12345666333, got requested for review even though you're not on the I therefore assumed being on the alias with the most privileges only should be enough. |
|
@cpanato @tao12345666333 Some details about the inheritance, I emphasized the important part: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners OWNERSEach directory that contains a unit of independent code or content may also contain an OWNERS file. OWNERS files are in YAML format and support the following keys:
The above keys constitute a simple OWNERS configuration. All users are expected to be assignable. In GitHub terms, this means they must be |
|
And another one @tao12345666333 approved even though he's not a member of the |
ingress-nginx-helm-maintainers: - cpanato: Covered by ingress-nginx-maintainers - strongjz: Covered by ingress-nginx-maintainers ingress-nginx-helm-reviewers: - cpanato: Covered by ingress-nginx-reviewers - strongjz: Covered by ingress-nginx-reviewers ingress-nginx-docs-maintainers: - tao12345666333: Covered by ingress-nginx-maintainers
|
/lgtm |
|
@msfidelis: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/honk |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cpanato
added
the
tide/merge-method-squash
|
|
||
| approvers: | ||
| - ingress-nginx-admins | ||
| - ingress-nginx-maintainers |
There was a problem hiding this comment.
i think we should keep at least the maintainers or drop the entire file
There was a problem hiding this comment.
But then we would also revoke reviewer privileges for @invidian. Is this intended?
There was a problem hiding this comment.
if the ingress-nginx-maintainers still works here then it is fine
There was a problem hiding this comment.
Yes, it should. I searched some older, already approved and merged PRs to check if the inheritance from the root OWNERS works, see above. According to my investigations and the docs it should work!
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Gacko, msfidelis, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Gacko: new pull request created: #11203 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR promotes myself to
ingress-nginx-maintainers&ingress-nginx-reviewers.It also re-organizes the existing owners and owner aliases to remove duplicates in aliases and inheritance.
Types of changes
Which issue/s this PR fixes
https://kubernetes.slack.com/archives/C021E147ZA4/p1711446319357989
How Has This Been Tested?
Not at all. CI will show us.
Checklist: